Use core.getBooleanInput() to resolve include-prerelease option
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nogic1008, could you please revert the lines in |
2 tasks
|
@nogic1008 , could you update your branch from main to fix license issue? |
|
@vsafonkin rebased. |
vsafonkin
reviewed
Dec 28, 2021
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
I'm sorry to have staled this PR. |
e-korolevskii
approved these changes
Jul 31, 2022
marko-zivic-93
approved these changes
Aug 1, 2022
dmitry-shibanov
approved these changes
Aug 1, 2022
| @@ -18,6 +18,7 @@ inputs: | |||
| include-prerelease: | |||
| description: 'Whether prerelease versions should be matched with non-exact versions (for example 5.0.0-preview.6 being matched by 5, 5.0, 5.x or 5.0.x). Defaults to false if not provided.' | |||
| required: False | |||
| default: 'false' | |||
There was a problem hiding this comment.
Could you please remove single quotes ?
There was a problem hiding this comment.
@dmitry-shibanov
GitHub Action schema warns this should be string. Should I still remove the quotes?
There was a problem hiding this comment.
I think it should be okay, because we use the similar approach for setup-node https://github.com/actions/setup-node/blob/main/action.yml#L16. But I think you can keep this variant due to the parsing logic of runner.
vsafonkin
approved these changes
Aug 2, 2022
marko-zivic-93
approved these changes
Aug 2, 2022
IvanZosimov
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
getBooleanInput()function was added since @actions/core@1.3.0 (actions/toolkit#725).This PR uses it to reduce code path.
include-prereleaseset invalid value.Related issue:
None.
Check list: